This repository was archived by the owner on Dec 12, 2018. It is now read-only.
Update resources regarding save() and delete()#567
Open
the-overengineer wants to merge 19 commits intomasterfrom
Open
Update resources regarding save() and delete()#567the-overengineer wants to merge 19 commits intomasterfrom
the-overengineer wants to merge 19 commits intomasterfrom
Conversation
added 19 commits
November 14, 2016 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes extraction of
.save()and.delete()resource actions into mixins. Provides JSDoc documentation regarding these and their use. Applies them both to theInstanceResource,while some other resources were made to inherit
Resourceand apply only one of these mixins(or even neither).
This is only the initial pass, one more comparison with the API and the API docs is neccessary.
Fixes #539